Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update katib-ui rockcraft.yaml #38

Merged
merged 5 commits into from
Dec 1, 2023
Merged

Conversation

ca-scribner
Copy link
Contributor

@ca-scribner ca-scribner commented Nov 28, 2023

Previously, an older version of the katib-ui had been rocked. This commit updates the rock to the current katib-ui, replicating the build defined by https://github.com/kubeflow/katib/blob/v0.16.0/cmd/ui/v1beta1/Dockerfile

Note:

  • the version of the frontend-lib pulled here is that specified by the katib repo in the COMMIT file of the upstream repo
  • the GOARCH is omitted from building here because upstream also omits this. This might be something to revisit later, or might be something determined in different ways in rocks anyway?

Closes #32

Testing instructions

Do:

VERSION=version_in_rockcraft_file
rockcraft pack
skopeo --insecure-policy copy oci-archive:katib-ui_${VERSION}_amd64.rock docker-daemon:katib-ui:${VERSION}
docker save katib-ui:${VERSION} > katib_ui_${VERSION}.tar
microk8s ctr image import katib_ui_${VERSION}.tar

Then do:

  • juju deploy katib-ui --resource oci-image=katib-ui:${VERSION} using a charm version includes this fix to the katib-ui charm
  • browse to KATIB_UI_SERVICE_IP:8080/katib/ and you should see the katib UI

Previously, an older version of the katib-ui had been rocked.  This commit updates the rock to the current katib-ui, replicating the build defined by https://github.com/kubeflow/katib/blob/v0.16.0/cmd/ui/v1beta1/Dockerfile
@ca-scribner ca-scribner marked this pull request as ready for review November 29, 2023 14:42
@ca-scribner ca-scribner requested a review from a team as a code owner November 29, 2023 14:42
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ca-scribner, great and structured work. I left some comments that are up for discussion. Didn't deploy and test the ROCK yet but will do tomorrow.

katib-ui-rock/rockcraft.yaml Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Outdated Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Outdated Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Outdated Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Outdated Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Outdated Show resolved Hide resolved
katib-ui-rock/rockcraft.yaml Show resolved Hide resolved
Copy link
Contributor

@orfeas-k orfeas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ca-scribner, tested it on a cluster and I can verify this works! Great job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

katib-ui-rock is based on wrong Dockerfile
2 participants