-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update katib-ui rockcraft.yaml #38
Conversation
Previously, an older version of the katib-ui had been rocked. This commit updates the rock to the current katib-ui, replicating the build defined by https://github.com/kubeflow/katib/blob/v0.16.0/cmd/ui/v1beta1/Dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @ca-scribner, great and structured work. I left some comments that are up for discussion. Didn't deploy and test the ROCK yet but will do tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ca-scribner, tested it on a cluster and I can verify this works! Great job
Previously, an older version of the katib-ui had been rocked. This commit updates the rock to the current katib-ui, replicating the build defined by https://github.com/kubeflow/katib/blob/v0.16.0/cmd/ui/v1beta1/Dockerfile
Note:
Closes #32
Testing instructions
Do:
Then do:
juju deploy katib-ui --resource oci-image=katib-ui:${VERSION}
using a charm version includes this fix to the katib-ui charmKATIB_UI_SERVICE_IP:8080/katib/
and you should see the katib UI